Bug 72047

Summary: #ifdef CPU(X86) specific div/mod code in DFGSpeculativeJIT32_64
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fix ggaren: review+

Gavin Barraclough
Reported 2011-11-10 13:02:20 PST
We currently don't attempt to abstract divide through the macro assembler, due to these instructions commonly having specific requirements. This means there is architecture specific code in the JIT - #ifdef it, and provide a common implementation.
Attachments
Fix (6.61 KB, patch)
2011-11-10 13:05 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-11-10 13:05:08 PST
Created attachment 114550 [details] Fix
Geoffrey Garen
Comment 2 2011-11-10 13:07:00 PST
Comment on attachment 114550 [details] Fix r=me
Gavin Barraclough
Comment 3 2011-11-10 13:08:27 PST
Fixed in r99892
Note You need to log in before you can comment on or make changes to this bug.