Summary: | Add NULL checks to setting access which is obtained on frame and document | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Grzegorz Czajkowski <g.czajkowski> | ||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ap, cshu, dglazkov, japhet, kling, rakuco, rniwa, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Grzegorz Czajkowski
2011-11-09 23:56:00 PST
Created attachment 114444 [details]
proposed patch
Comment on attachment 114444 [details] proposed patch Attachment 114444 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10354296 Comment on attachment 114444 [details] proposed patch Attachment 114444 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10401241 New failing tests: editing/input/password-echo-passnode.html editing/input/password-echo-passnode2.html Created attachment 115133 [details]
updated patch
Fix WebKit-Qt build break
Comment on attachment 115133 [details] updated patch Attachment 115133 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10483285 New failing tests: editing/input/password-echo-passnode.html editing/input/password-echo-passnode2.html Hello Dimitri and Nate, Can you confirm that this patch may cause failing of those tests? I don't have environment with Chromium DumpRenderTree application so I'd glad to hear your opinion. Thanks. Comment on attachment 115133 [details]
updated patch
OK. Can we test this?
(In reply to comment #5) > (From update of attachment 115133 [details]) > Attachment 115133 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/10483285 > > New failing tests: > editing/input/password-echo-passnode.html > editing/input/password-echo-passnode2.html Your patch probably breaks these two tests on all platforms (note: only cr-linux EWS bots run tests). (In reply to comment #8) > (In reply to comment #5) > > (From update of attachment 115133 [details] [details]) > > Attachment 115133 [details] [details] did not pass chromium-ews (chromium-xvfb): > > Output: http://queues.webkit.org/results/10483285 > > > > New failing tests: > > editing/input/password-echo-passnode.html > > editing/input/password-echo-passnode2.html > > Your patch probably breaks these two tests on all platforms (note: only cr-linux EWS bots run tests). CC'ing Andreas Kling. Ok, Andreas has found bug in the patch. I will fix it. Created attachment 121815 [details]
updated patch
Fixes bug which caused failing of tests.
Comment on attachment 121815 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=121815&action=review > Source/WebCore/ChangeLog:8 > + Adds NULL checks to seeting object where it's required. Typo, settings. Created attachment 121823 [details]
patch for landing
Fixed typo.
For the record, it's unfortunate that we don't have tests for these changes. However I believe these null-checks are sane and belong in WebKit. In the future, please provide tests that exercise your changes, or explain why tests aren't possible. Comment on attachment 121823 [details] patch for landing Clearing flags on attachment: 121823 Committed r104552: <http://trac.webkit.org/changeset/104552> All reviewed patches have been landed. Closing bug. |