|Summary:||Gradient appears and disappears in SVG when text is off screen|
|Product:||WebKit||Reporter:||Alexander Kellett <a>|
|Component:||SVG||Assignee:||Nikolas Zimmermann <zimmermann>|
|OS:||OS X 10.4|
Description Alexander Kellett 2006-02-11 15:14:44 PST
scrolling off the side of http://bugzilla.opendarwin.org/attachment.cgi?id=6042 shows the issue
Comment 1 Nikolas Zimmermann 2007-01-02 06:19:56 PST
Created attachment 12159 [details] Reduced testcase. The problem is actually, because of <tspan> in <text>, that breaks "gradient-on-text".
Comment 2 Eric Seidel (no email) 2007-01-31 04:51:24 PST
I can't tell if this is fixed. Niko?
Comment 3 Nikolas Zimmermann 2007-02-04 05:15:49 PST
(In reply to comment #2) > I can't tell if this is fixed. Niko? > Nope, problem is still persistent. Not sure how to fix yet. Niko
Comment 4 Nikolas Zimmermann 2007-09-03 14:16:20 PDT
Created attachment 16187 [details] Initial patch Not ready for review yet. Just for Oliver :-)
Comment 5 Nikolas Zimmermann 2007-09-03 15:32:46 PDT
Created attachment 16188 [details] Updated patch The reduced testcase is obsolete as the problem gets highlighted by a different (already commited) batik/text testcase.
Comment 6 Nikolas Zimmermann 2007-09-03 15:43:54 PDT
Created attachment 16189 [details] Updated patch v2 Some last hot fixes - demanded by Oliver. Seperated LayoutTests/ and patch upon request.
Comment 7 Nikolas Zimmermann 2007-09-03 15:44:59 PDT
Created attachment 16190 [details] Layout test results
Comment 8 Oliver Hunt 2007-09-04 01:30:16 PDT
Comment on attachment 16189 [details] Updated patch v2 Basically looks good, but i find myself wondering about SVGTextChunkWalkerBase and SVGTextChunkWalker, as it seems unnecessary to use both virtual methods *and* function pointers.
Comment 9 Oliver Hunt 2007-09-04 01:36:23 PDT
i'll r+ this if you can justify the exciting combo of function pointer and virtual methods in SVGTextChunkWalkerBase
Comment 10 Nikolas Zimmermann 2007-09-04 04:43:32 PDT
(In reply to comment #9) > i'll r+ this if you can justify the exciting combo of function pointer and > virtual methods in SVGTextChunkWalkerBase Hey Oliver, yeah nice combination :-) In fact I added SVGTextChunkWalkerBase later on, as it made it possible to remove the template based implementation of "walkTextChunks" in SVGRootInlineBox.h - I didn't like the fact to have crucial methods sitting in header files. Greetings, Niko
Comment 11 Oliver Hunt 2007-09-05 11:20:25 PDT
Comment on attachment 16190 [details] Layout test results changes look sane, rubber stamping