Bug 71914 – [Qt] Enable skipped but now passing tests (media)

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

[Zoltan Arvai]

"run-webkit-tests --no-launch-safari --no-sample-on-timeout --no-new-test-results --results-directory layout-test-results --use-remote-links-to-tests --release --qt --force media" is resulting a resonable amount of "Expected to fail, but passed" tests. 
This should be examined and passing tests should be unskipped.

https://lists.webkit.org/pipermail/webkit-qt/2011-November/002078.html

[Zoltan Arvai]

Created attachment 116506 [details]
unkip media

Tested with Ubuntu 11.10 x64 and Debian Squeeze x86.

[Alexis Menard (darktears)]

(In reply to comment #1)
> Created an attachment (id=116506) [details]
> unkip media
> 
> Tested with Ubuntu 11.10 x64 and Debian Squeeze x86.

But on the bot they don't pass for some reason.

[Simon Hausmann]

Comment on attachment 116506 [details]
unkip media

View in context: https://bugs.webkit.org/attachment.cgi?id=116506&action=review

> LayoutTests/platform/qt/Skipped:1603
> +#media/video-can-play-type.html
> +#media/video-delay-load-event.html

If they pass, why leave the lines with the unskipped tests around, commented out?

[Zoltan Arvai]

(In reply to comment #3)
> (From update of attachment 116506 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=116506&action=review
> 
> > LayoutTests/platform/qt/Skipped:1603
> > +#media/video-can-play-type.html
> > +#media/video-delay-load-event.html
> 
> If they pass, why leave the lines with the unskipped tests around, commented out?

Sry, that was my bad.

[Zoltan Arvai]

Created attachment 116511 [details]
unskip media

Corrected patch.

[Zoltan Arvai]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=116506) [details] [details]
> > unkip media
> > 
> > Tested with Ubuntu 11.10 x64 and Debian Squeeze x86.
> 
> But on the bot they don't pass for some reason.

Can you show me which media tests are failing, please?

[Simon Hausmann]

Comment on attachment 116511 [details]
unskip media

View in context: https://bugs.webkit.org/attachment.cgi?id=116511&action=review

> LayoutTests/platform/qt/Skipped:-569
> -# https://bugs.webkit.org/show_bug.cgi?id=57983

One other note: The bugs referred to here, I guess they should be closed or marked as duplicate of this bug? (once this patch lands)

[Csaba Osztrogonác]

Comment on attachment 116511 [details]
unskip media

r- now, many of them still fail for me. It seem media tests are still flakey.
Let's check them one more time.

[Csaba Osztrogonác]

I don't think if we have time to experiment with the hiperflakey media tests.