Bug 71875

Summary: Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, rniwa, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70565    
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Darin Adler
Reported 2011-11-08 22:30:21 PST
Add code path in HashTable for emptyValueIsZero that does not require copying the empty value
Attachments
Patch (5.82 KB, patch)
2011-11-08 22:35 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (9.31 KB, patch)
2011-11-09 10:05 PST, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2011-11-08 22:35:29 PST
Created attachment 114208 [details] Patch
Darin Adler
Comment 2 2011-11-09 09:12:14 PST
Comment on attachment 114208 [details] Patch It’s wrong to assume that emptyValueIsZero also means that you can default construct.
Darin Adler
Comment 3 2011-11-09 10:05:55 PST
Created attachment 114307 [details] Patch
WebKit Review Bot
Comment 4 2011-11-09 10:08:23 PST
Attachment 114307 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/Alignment.h:40: __attribute__ is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/Alignment.h:46: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:47: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:48: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:49: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:50: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:51: More than one command on the same line [whitespace/newline] [4] Source/JavaScriptCore/wtf/Alignment.h:52: More than one command on the same line [whitespace/newline] [4] Total errors found: 8 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 5 2011-11-09 10:09:11 PST
Comment on attachment 114307 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114307&action=review > Source/JavaScriptCore/wtf/HashTable.h:642 > + // The memset to 0 looks like a slow operation is optimized by the compilers. Looks like a missing "but" here.
Darin Adler
Comment 6 2011-11-09 10:11:53 PST
Committed r99733: <http://trac.webkit.org/changeset/99733>
Note You need to log in before you can comment on or make changes to this bug.