Bug 71867
Summary: | Move code to handle 8bit regs from X86Assembler to MacroAssembler | ||
---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> |
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | ||
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Gavin Barraclough
This code is fine, but is in the wrong place really. X86 assembler should basically just format up exactly the instruction you request - not expand out to a set of instructions (that is what the macro assembler layer is for!). For other 8-bit ops, on X86 we don't guard against clients accessing the XH registers.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Gavin Barraclough
Fixed in r99640