Summary: | MHTML documents containing references to resources they don't include never finish loading | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jay Civelli <jcivelli> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Jay Civelli <jcivelli> | ||||||||||||
Status: | REOPENED --- | ||||||||||||||
Severity: | Normal | CC: | abarth, japhet, jochen, tonyg, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 72109, 89935 | ||||||||||||||
Bug Blocks: | |||||||||||||||
Attachments: |
|
Description
Jay Civelli
2011-11-08 14:53:56 PST
Created attachment 114159 [details]
Patch
Created attachment 114163 [details]
Patch
Comment on attachment 114163 [details]
Patch
Test?
Created attachment 114442 [details]
Patch
Added a Chromium test for this (as this cannot be tested with a LayoutTest). Comment on attachment 114442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114442&action=review > Source/WebCore/loader/DocumentLoader.cpp:660 > + return true; > + } > + return false; I would have combined these to "return failLoad", but that's just a nit. Comment on attachment 114442 [details] Patch Clearing flags on attachment: 114442 Committed r99826: <http://trac.webkit.org/changeset/99826> All reviewed patches have been landed. Closing bug. Created attachment 146168 [details]
Patch
Reviving this bug. Uploaded a newer patch. @japhet: Any interest in reviewing this patch? Comment on attachment 146168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146168&action=review > Source/WebCore/loader/DocumentLoader.cpp:694 > + // Schedule this loader without a resource so that resource completion/failure notifications are still fired. > + m_pendingSubstituteResources.set(loader, 0); > + deliverSubstituteResourcesAfterDelay(); It might make sense to be a little more explicit here that didFail() will get called via substituteResourceDeliveryTimerFired() for a null SubstituteResource. It wasn't immediately obvious to me that this was safe. Created attachment 149348 [details]
Patch for landing
Comment on attachment 149348 [details] Patch for landing Clearing flags on attachment: 149348 Committed r121206: <http://trac.webkit.org/changeset/121206> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by 89935 |