Bug 71859

Summary: MHTML documents containing references to resources they don't include never finish loading
Product: WebKit Reporter: Jay Civelli <jcivelli>
Component: WebCore Misc.Assignee: Jay Civelli <jcivelli>
Status: REOPENED    
Severity: Normal CC: abarth, japhet, jochen, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72109, 89935    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch for landing none

Jay Civelli
Reported 2011-11-08 14:53:56 PST
Save a page such as cnn.com to MHTML. Load the generated MHTML. The page gets loaded, but we never get a notification that the load stopped (and the progress never gets to 100%).
Attachments
Patch (3.67 KB, patch)
2011-11-08 14:55 PST, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2011-11-08 15:24 PST, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch (13.60 KB, patch)
2011-11-09 23:36 PST, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch (12.74 KB, patch)
2012-06-06 18:13 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Patch for landing (13.73 KB, patch)
2012-06-25 13:57 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jay Civelli
Comment 1 2011-11-08 14:55:44 PST
Created attachment 114159 [details] Patch
Jay Civelli
Comment 2 2011-11-08 15:24:37 PST
Created attachment 114163 [details] Patch
Adam Barth
Comment 3 2011-11-08 16:09:49 PST
Comment on attachment 114163 [details] Patch Test?
Jay Civelli
Comment 4 2011-11-09 23:36:46 PST
Created attachment 114442 [details] Patch
Jay Civelli
Comment 5 2011-11-09 23:40:34 PST
Added a Chromium test for this (as this cannot be tested with a LayoutTest).
Adam Barth
Comment 6 2011-11-09 23:53:25 PST
Comment on attachment 114442 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114442&action=review > Source/WebCore/loader/DocumentLoader.cpp:660 > + return true; > + } > + return false; I would have combined these to "return failLoad", but that's just a nit.
WebKit Review Bot
Comment 7 2011-11-10 01:39:58 PST
Comment on attachment 114442 [details] Patch Clearing flags on attachment: 114442 Committed r99826: <http://trac.webkit.org/changeset/99826>
WebKit Review Bot
Comment 8 2011-11-10 01:40:03 PST
All reviewed patches have been landed. Closing bug.
Tony Gentilcore
Comment 9 2011-11-11 03:31:58 PST
Reopening as I'm rolling this out in bug 72109. Explanation in bug 72039.
Jay Civelli
Comment 10 2012-06-06 18:13:43 PDT
Created attachment 146168 [details] Patch
Jay Civelli
Comment 11 2012-06-06 18:14:36 PDT
Reviving this bug. Uploaded a newer patch.
Adam Barth
Comment 12 2012-06-07 15:24:04 PDT
@japhet: Any interest in reviewing this patch?
Nate Chapin
Comment 13 2012-06-25 11:41:15 PDT
Comment on attachment 146168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=146168&action=review > Source/WebCore/loader/DocumentLoader.cpp:694 > + // Schedule this loader without a resource so that resource completion/failure notifications are still fired. > + m_pendingSubstituteResources.set(loader, 0); > + deliverSubstituteResourcesAfterDelay(); It might make sense to be a little more explicit here that didFail() will get called via substituteResourceDeliveryTimerFired() for a null SubstituteResource. It wasn't immediately obvious to me that this was safe.
Jay Civelli
Comment 14 2012-06-25 13:57:43 PDT
Created attachment 149348 [details] Patch for landing
WebKit Review Bot
Comment 15 2012-06-25 18:12:22 PDT
Comment on attachment 149348 [details] Patch for landing Clearing flags on attachment: 149348 Committed r121206: <http://trac.webkit.org/changeset/121206>
WebKit Review Bot
Comment 16 2012-06-25 18:12:28 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 17 2012-06-25 19:06:14 PDT
Re-opened since this is blocked by 89935
Note You need to log in before you can comment on or make changes to this bug.