Bug 71848

Summary: Web Inspector: ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
Product: WebKit Reporter: Vsevolod Vlasov <vsevik>
Component: Web Inspector (Deprecated)Assignee: Vsevolod Vlasov <vsevik>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch pfeldman: review+

Vsevolod Vlasov
Reported 2011-11-08 12:47:37 PST
ResourcesPanel should support adding subtitle to any BaseStorageTreeElement.
Attachments
Patch (4.53 KB, patch)
2011-11-08 12:50 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (5.35 KB, patch)
2011-11-08 13:41 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (5.47 KB, patch)
2011-11-08 13:43 PST, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (6.27 KB, patch)
2011-11-09 02:24 PST, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2011-11-08 12:50:32 PST
Created attachment 114139 [details] Patch
Vsevolod Vlasov
Comment 2 2011-11-08 12:51:24 PST
We will need that to create tree elements for frames with particular application cache manifest.
Vsevolod Vlasov
Comment 3 2011-11-08 13:41:01 PST
Created attachment 114146 [details] Patch
Vsevolod Vlasov
Comment 4 2011-11-08 13:43:58 PST
Created attachment 114147 [details] Patch
Pavel Feldman
Comment 5 2011-11-08 20:52:09 PST
Comment on attachment 114147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114147&action=review > Source/WebCore/inspector/front-end/ResourcesPanel.js:870 > + this._updateTitles(); I know why you are setting titles when element is in the tree, but you could 'force' it and do it before. > Source/WebCore/inspector/front-end/ResourcesPanel.js:929 > + this._updateTitles(); So the common sequence below is at risk of creating title element twice?: treeElement.titleText = "foo"; treeElement.subtitleText = "bar"; I would manage title setters separately: title setter only changes its text, while preserving the subtitle + subtitle lazily creates / updates subtitle element. And you have to force both on attach.
Vsevolod Vlasov
Comment 6 2011-11-09 02:24:54 PST
Created attachment 114227 [details] Patch
Vsevolod Vlasov
Comment 7 2011-11-09 03:58:18 PST
Committed r99686: <http://trac.webkit.org/changeset/99686>
Note You need to log in before you can comment on or make changes to this bug.