Bug 71845

Summary: Use a typedef for ExceptionCode in all header files instead of including ExceptionCode.h
Product: WebKit Reporter: Adam Klein <adamk>
Component: New BugsAssignee: Adam Klein <adamk>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, macpherson, rniwa, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Adam Klein
Reported 2011-11-08 12:17:49 PST
Use a typedef for ExceptionCode in all header files instead of including ExceptionCode.h
Attachments
Patch (51.01 KB, patch)
2011-11-08 12:20 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Patch for landing (51.64 KB, patch)
2011-11-08 15:22 PST, Adam Klein 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Klein
Comment 1 2011-11-08 12:20:36 PST
Created attachment 114132 [details] Patch
Adam Klein
Comment 2 2011-11-08 12:26:29 PST
Thanks for the r+, will wait a bit for the EWS runs and for Darin to comment before landing.
Darin Adler
Comment 3 2011-11-08 14:07:56 PST
Comment on attachment 114132 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114132&action=review I like it. > Source/WebCore/html/TimeRanges.cpp:32 > +#include "ExceptionCode.h" > + > #include <math.h> There shouldn’t be a blank line here. WebKit style doesn’t put the "" includes and the <> includes into separate paragraphs, even though people did that in some files.
Adam Klein
Comment 4 2011-11-08 15:22:13 PST
Created attachment 114162 [details] Patch for landing
WebKit Review Bot
Comment 5 2011-11-08 17:53:34 PST
Comment on attachment 114162 [details] Patch for landing Clearing flags on attachment: 114162 Committed r99645: <http://trac.webkit.org/changeset/99645>
WebKit Review Bot
Comment 6 2011-11-08 17:53:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.