Allow RenderView to have columns

• Component: Layout and Rendering
• Status: RESOLVED FIXED

<rdar://problem/10262225>

This is a way to enable clients to present paginated content.

Created attachment 114127 [details]
Allow RenderView to have columns when the Page requests pagination

[Simon Fraser (smfr)]

Comment on attachment 114127 [details]
Allow RenderView to have columns when the Page requests pagination

View in context: https://bugs.webkit.org/attachment.cgi?id=114127&action=review

> Source/WebCore/page/Page.h:264
> +            unsigned gap;

What is 'gap' here?

> Source/WebCore/rendering/RenderBlock.cpp:4519
> +    bool destroyColumns = !requiresColumns(count);

destroyColumns doesn't seem like quite the right name; you only need to destroy if you have some already.

(In reply to comment #2)
> (From update of attachment 114127 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=114127&action=review
> 
> > Source/WebCore/page/Page.h:264
> > +            unsigned gap;
> 
> What is 'gap' here?

Distance between adjacent pages.

Landed in <http://trac.webkit.org/r99613>.

[Xan Lopez]

This seems to have broken the GTK+ bots.

[Daniel Bates]

(In reply to comment #5)
> This seems to have broken the GTK+ bots.

Added symbol _ZN7WebCore4Page13setPaginationERKNS0_10PaginationE to file Source/autotools/symbols.filter.

Committed in changeset 99646 <http://trac.webkit.org/changeset/99646>.

[Philippe Normand]

(In reply to comment #5)
> This seems to have broken the GTK+ bots.

Lots of new flaky tests yes :(

[Xan Lopez]

(In reply to comment #7)
> (In reply to comment #5)
> > This seems to have broken the GTK+ bots.
> 
> Lots of new flaky tests yes :(

I actually only meant broken as in "the build is broken", which apparently Daniel fixed already (thanks!). Sorry for not being specific, it was 3 AM :)