Bug 71834

Summary: [Mac] Disable C++ exceptions from DumpRenderTree
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ddkilzer, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 71866    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2011-11-08 10:36:28 PST
C++ exceptions are not handled in the Mac implementation of DumpRenderTree. They causes hard to debug issues, let's disable C++ exceptions so we see the problems where it happens.
Attachments
Patch (2.21 KB, patch)
2011-11-08 10:46 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-11-08 10:46:42 PST
Created attachment 114114 [details] Patch
Darin Adler
Comment 2 2011-11-08 13:44:58 PST
Comment on attachment 114114 [details] Patch Sounds good. I don’t see any downside.
WebKit Review Bot
Comment 3 2011-11-08 15:57:38 PST
Comment on attachment 114114 [details] Patch Clearing flags on attachment: 114114 Committed r99626: <http://trac.webkit.org/changeset/99626>
WebKit Review Bot
Comment 4 2011-11-08 15:57:42 PST
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 5 2011-11-08 19:37:13 PST
Mark Rowe discovered GCC breaks Objective-C exceptions when disabling C++ exceptions on 32 bits. JavaScriptCore has a workaround for this problem: // Work around bug with C++ library that screws up Objective-C++ when exception support is disabled. #undef try #undef catch I don't think that is worth adding that to DumpRenderTree. It would be adding complexity for a small corner case.
Note You need to log in before you can comment on or make changes to this bug.