| Summary: | [chromium] remove the deprecated rebaseline script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
| Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dpranke, eric, ojan, rniwa, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tony Chang
2011-11-08 10:32:48 PST
Created attachment 114112 [details]
Patch
Comment on attachment 114112 [details]
Patch
YES.
Comment on attachment 114112 [details]
Patch
Please don't remove this tool. I actively use it.
New tool is practically unusable for me for the reasons stated in the webkit-dev thread. FWIW, I also don't find webkit-patch rebaseline a complete replacement for rebaseline-chromium-... Things I miss: 1) visual diff of what's changed. rebaseline-chromium's visual diff was buggy, but was useful when it worked. If we could make webkit-patch pretty-diff work, that would be good enough. 2) The last time I looked, it was pretty much impossible to figure out what webkit-patch rebaseline actually did, and why. I had spent a fair amount of time cleaning up the logging in rebaseline-chromium so that you could tell what did get updated and why. In addition, combining the "update baselines" step with the "optimize baselines" step makes it very difficult to figure out what is actually going on. I don't want to stop us from getting rid of old code, so I would be fine w/ obsoleting this now as long as someone was actively working on these tools/enhancements in the near future. Saying "patches welcome" is not good enough ;) FWIW, I don't think it's important to understand why certain files are in certain directories. The tool should do the right thing and we shouldn't require people to understand it. Having a visual diff for a specific platform seems useful though. We should probably just fix the flakiness dashboard or garden-o-matic to do this instead of just barfing up a bunch of iframes. Looks like this script was removed at some point. |