Bug 71815

Summary: [Qt] Build system cleanup
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: New BugsAssignee: Simon Hausmann <hausmann>
Status: RESOLVED FIXED    
Severity: Normal CC: vestbo, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[Qt] Build system cleanup kenneth: review+

Simon Hausmann
Reported 2011-11-08 07:42:57 PST
[Qt] Build system cleanup
Attachments
[Qt] Build system cleanup (8.33 KB, patch)
2011-11-08 07:49 PST, Simon Hausmann 		kenneth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2011-11-08 07:49:03 PST
Created attachment 114064 [details] [Qt] Build system cleanup
Simon Hausmann
Comment 2 2011-11-08 07:50:02 PST
These patches are in preparation for introducing --whole-archive :)
Kenneth Rohde Christiansen
Comment 3 2011-11-08 07:54:44 PST
Comment on attachment 114064 [details] [Qt] Build system cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=114064&action=review > Tools/ChangeLog:11 > + * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency > + (ownPtr functions for glib types). Propagate that to everyone using javascriptcore. Maybe it is time to build wtf separately? There is talk about splitting it out anyway
Kenneth Rohde Christiansen
Comment 4 2011-11-08 07:55:33 PST
Comment on attachment 114064 [details] [Qt] Build system cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=114064&action=review > Source/WebKit2/Target.pri:-24 > -WEBKIT1_HEADERS_SHARED_WITH_WEBKIT2= \ > - $$PWD/../WebKit/qt/WebCoreSupport/QtWebComboBox.h > - > -WEBKIT1_SOURCES_SHARED_WITH_WEBKIT2 = \ > - $$PWD/../WebKit/qt/WebCoreSupport/QtWebComboBox.cpp I didnt see you mentioning these in the changelog
Simon Hausmann
Comment 5 2011-11-08 07:57:56 PST
Comment on attachment 114064 [details] [Qt] Build system cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=114064&action=review >> Source/WebKit2/Target.pri:-24 >> - $$PWD/../WebKit/qt/WebCoreSupport/QtWebComboBox.cpp > > I didnt see you mentioning these in the changelog It's this part from the ChangeLog: Target.pri: "Removed duplicated sources that are compiled also into QtWebKit.so through api.pri." >> Tools/ChangeLog:11 >> + (ownPtr functions for glib types). Propagate that to everyone using javascriptcore. > > Maybe it is time to build wtf separately? There is talk about splitting it out anyway Yeah, I think once that moves happens we should follow. But not at the moment IMHO.
Kenneth Rohde Christiansen
Comment 6 2011-11-08 08:00:09 PST
Comment on attachment 114064 [details] [Qt] Build system cleanup Sorry missed that one!
Tor Arne Vestbø
Comment 7 2011-11-08 11:07:02 PST
nice!
Simon Hausmann
Comment 8 2011-11-09 00:53:07 PST
Committed r99666: <http://trac.webkit.org/changeset/99666>
Note You need to log in before you can comment on or make changes to this bug.