Summary: | CSSValue: Devirtualize cssText(). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | CSS | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | macpherson, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 71666 | ||||||
Attachments: |
|
Description
Andreas Kling
2011-11-08 07:11:08 PST
Created attachment 114059 [details]
Patch!
Comment on attachment 114059 [details]
Patch!
r=me
Attachment 114059 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/css/CSSValue.cpp:32: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/css/CSSValue.cpp:51: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/css/CSSValue.cpp:54: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 53 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r99567: <http://trac.webkit.org/changeset/99567> Comment on attachment 114059 [details]
Patch!
Should be customCSSText not customCssText, with our WebKit naming style.
|