Bug 71785

Summary: Fold ImageBySizeCache again into CSSImageGeneratorValue
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: CSSAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zherczeg: review+

Nikolas Zimmermann
Reported 2011-11-08 01:53:07 PST
Fold ImageBySizeCache again into CSSImageGeneratorValue. It's no longer needed by CachedImage and thus we can remove this extra layer of abstraction again.
Attachments
Patch (19.03 KB, patch)
2011-11-08 03:20 PST, Nikolas Zimmermann 		zherczeg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2011-11-08 03:20:09 PST
Created attachment 114028 [details] Patch
Zoltan Herczeg
Comment 2 2011-11-08 03:54:06 PST
Comment on attachment 114028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114028&action=review > Source/WebCore/ChangeLog:9 > + CachedImage has switched to SVGImageCache and now longer needs it. no longer needs it r=me Please wait for all bots before landing.
Nikolas Zimmermann
Comment 3 2011-11-08 04:28:29 PST
(In reply to comment #2) > (From update of attachment 114028 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=114028&action=review > > > Source/WebCore/ChangeLog:9 > > + CachedImage has switched to SVGImageCache and now longer needs it. > > no longer needs it > > r=me > > Please wait for all bots before landing. Mac slave is hosed, I'm trying manually.
Nikolas Zimmermann
Comment 4 2011-11-08 04:30:21 PST
Landed in r99549.
Note You need to log in before you can comment on or make changes to this bug.