Bug 71783

Summary:

Web Inspector: Avoid automatic Console suggestions with empty expression

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	yurys: review+

Alexander Pavlov (apavlov)

Reported 2011-11-08 01:36:30 PST

Enter ";" in the console - entire global scope suggestions will be displayed.

Attachments
Patch (1.59 KB, patch) 2011-11-08 01:39 PST, Alexander Pavlov (apavlov)	no flags	Details Formatted Diff Diff
Patch (1.90 KB, patch) 2011-11-08 01:45 PST, Alexander Pavlov (apavlov)	yurys: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2011-11-08 01:39:34 PST

Pavel Feldman

Comment 2 2011-11-08 01:40:56 PST

Comment on attachment 114012 [details] Patch We should call the callback.

Alexander Pavlov (apavlov)

Comment 3 2011-11-08 01:45:41 PST

Yury Semikhatsky

Comment 4 2011-11-08 02:59:57 PST

Comment on attachment 114013 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114013&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:368 > + completionsReadyCallback([]); Prefer early return.

Alexander Pavlov (apavlov)

Comment 5 2011-11-08 04:22:39 PST

Note You need to log in before you can comment on or make changes to this bug.