Bug 71767

Summary: [GTK][EFL] NWRT should check that Xvfb is installed
Product: WebKit Reporter: vanuan
Component: Tools / TestsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, mrobinson, rakuco, webkit.review.bot, zan
Priority: P2 Keywords: NRWT
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

vanuan
Reported 2011-11-07 22:34:13 PST
NRWT is crashing when xvfb is not installed: AttributeError: GtkDriver instance has no attribute '_server_process' worker/0 raised OSError('[Errno 2] No such file or directory'): Full traceback: http://pastebin.com/B5pE8AJg Giving a warning to check if all dependencies is installed instead of crashing with exception would be great.
Attachments
Patch (3.55 KB, patch)
2013-01-16 03:09 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-08-01 18:30:50 PDT
This is the point of the Port.check_sys_deps() method. Sounds like Gtk and EFL should be overriding this to look for Xvfb? Updating subject accordingly ...
Raphael Kubo da Costa (:rakuco)
Comment 2 2012-08-13 15:45:12 PDT
The EFL port doesn't use Xvfb, rewording the title to make it GTK-only.
Zan Dobersek
Comment 3 2013-01-16 03:01:47 PST
(In reply to comment #2) > The EFL port doesn't use Xvfb, rewording the title to make it GTK-only. It does now.
Zan Dobersek
Comment 4 2013-01-16 03:09:38 PST
Created attachment 182951 [details] Patch
Zan Dobersek
Comment 5 2013-01-17 02:00:13 PST
Comment on attachment 182951 [details] Patch Clearing flags on attachment: 182951 Committed r139973: <http://trac.webkit.org/changeset/139973>
Zan Dobersek
Comment 6 2013-01-17 02:00:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.