Bug 71761

Summary:

Towards 8 Bit Strings: Templatize JSC::Parser class by Lexer type

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

71337

Attachments:

Description	Flags
Proposed Patch	none
Updated patch	oliver: review-
Updated Patch	oliver: review+

Michael Saboff

Reported 2011-11-07 19:42:43 PST

This is a follow on to https://bugs.webkit.org/show_bug.cgi?id=71331, where the Lexer was templatized.

Attachments
Proposed Patch (26.05 KB, patch) 2011-11-07 19:53 PST, Michael Saboff	no flags	Details Formatted Diff Diff
Updated patch (37.56 KB, patch) 2011-11-08 10:50 PST, Michael Saboff	oliver: review-	Details Formatted Diff Diff
Updated Patch (38.03 KB, patch) 2011-11-08 13:21 PST, Michael Saboff	oliver: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Michael Saboff

Comment 1 2011-11-07 19:53:37 PST

Created attachment 113982 [details] Proposed Patch

Michael Saboff

Comment 2 2011-11-08 10:50:11 PST

Created attachment 114117 [details] Updated patch

Oliver Hunt

Comment 3 2011-11-08 12:04:11 PST

Comment on attachment 114117 [details] Updated patch Can you rename T to LexerType, also could you break out the Lexer<UChar>* to OwnPtr<Lexer<UChar> > change into a separate patch? there's a bug covering that leak that i'd like to keep separate

Michael Saboff

Comment 4 2011-11-08 13:21:00 PST

Created attachment 114142 [details] Updated Patch Split out the memory leak fix to https://bugs.webkit.org/show_bug.cgi?id=71847 and changed the template type name to LexerType.

Michael Saboff

Comment 5 2011-11-08 15:04:12 PST

Committed r99618: <http://trac.webkit.org/changeset/99618>

Note You need to log in before you can comment on or make changes to this bug.