Bug 71759

Summary: [Qt] Removing qwebkitglobal.h inclusion from qwebkitplatformplugin.h
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Luiz Agostini
Reported 2011-11-07 18:57:38 PST
This inclusion is wrong because it forces the plugins to depend on qwebkitglobal.h. The inclusion does not seem to be needed anyway. The of qwebkitplatformplugin.h copy that is inside the examples directory is pretty old and will be updated as well.
Attachments
patch (6.11 KB, patch)
2011-11-07 19:05 PST, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2011-11-07 19:05:53 PST
Created attachment 113977 [details] patch
Simon Hausmann
Comment 2 2011-11-07 23:52:40 PST
Comment on attachment 113977 [details] patch Thanks :)
WebKit Review Bot
Comment 3 2011-11-08 01:01:54 PST
Comment on attachment 113977 [details] patch Clearing flags on attachment: 113977 Committed r99535: <http://trac.webkit.org/changeset/99535>
WebKit Review Bot
Comment 4 2011-11-08 01:01:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.