Bug 71754

Summary: Indent command can insert block quote in non editable content
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, darin, rniwa, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test case
none
work in progress
none
fixes the bug
none
Updated per comment enrica: review+

Enrica Casucci
Reported 2011-11-07 17:30:49 PST
run the attached test case. EXPECTED The markup should be <body contenteditable> <blockquote …> <img><img> </blockquote> </body> ACTUAL <blockquote …> <img><img> </blockquote> <body contenteditable></body> The blockquote is inserted outside the editable content and the original content of the body is moved in non editable area.
Attachments
Test case (271 bytes, text/html)
2011-11-07 17:31 PST, Enrica Casucci 		no flags
Details
work in progress (2.38 KB, patch)
2011-11-07 18:10 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
fixes the bug (7.24 KB, patch)
2011-11-07 19:21 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Updated per comment (10.43 KB, patch)
2011-11-08 10:25 PST, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2011-11-07 17:31:10 PST
Created attachment 113967 [details] Test case
Ryosuke Niwa
Comment 2 2011-11-07 18:10:55 PST
Created attachment 113969 [details] work in progress Still doesn't work due to a bunch of bugs in CompositeEditCommand::cloneParagraphUnderNewElement. It needs be updated using modern syntax instead of deprecatedNode.
Ryosuke Niwa
Comment 3 2011-11-07 19:21:05 PST
Created attachment 113979 [details] fixes the bug
Enrica Casucci
Comment 4 2011-11-08 10:00:02 PST
Comment on attachment 113979 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=113979&action=review The patch doesnt cover every case. It would be nice to add more cases to the test. Definitely the one I mentioned above and probably the case were the root editable element is an inline. > Source/WebCore/editing/CompositeEditCommand.cpp:796 > + } This code will not work in every case. If you have <body><div contenteditable><img><img></div></body> the blockquote will still be inserted outside the div. I believe the correct test should be to check if outer node is the root editable element.
Ryosuke Niwa
Comment 5 2011-11-08 10:25:38 PST
Created attachment 114110 [details] Updated per comment
Enrica Casucci
Comment 6 2011-11-08 10:30:39 PST
Comment on attachment 114110 [details] Updated per comment Looks good now. Thanks for the quick followup!
Ryosuke Niwa
Comment 7 2011-11-08 10:40:01 PST
Committed r99594: <http://trac.webkit.org/changeset/99594>
Note You need to log in before you can comment on or make changes to this bug.