Bug 71701

Summary: Remove initWebKitTransitionEvent method
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Dominic Cooney <dominicc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68791    
Attachments:
Description Flags
Patch ojan: review+

Dominic Cooney
Reported 2011-11-07 09:30:44 PST
Code Search indicates nobody uses this method. Now that WebKitTransitionEvent has a constructor, this method should be removed.
Attachments
Patch (7.54 KB, patch)
2011-11-07 09:43 PST, Dominic Cooney 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-11-07 09:43:02 PST
Created attachment 113884 [details] Patch
Ojan Vafai
Comment 2 2011-11-07 10:12:55 PST
Comment on attachment 113884 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113884&action=review > Source/WebCore/ChangeLog:9 > + Now that WebKitTransitionEvent has a constructor, we don't need > + this method. Please include the information that init*Event methods have been removed from the spec.
Dominic Cooney
Comment 3 2011-12-25 22:08:48 PST
Comment on attachment 113884 [details] Patch Removing this from the commit queue for now. I filed <https://www.w3.org/Bugs/Public/show_bug.cgi?id=15339> to remove the initTransitionEvent from the spec.
Ojan Vafai
Comment 4 2011-12-26 10:07:06 PST
I don't think you need to wait for the spec to be updated here. The platform as a whole is clearly moving in this direction, so it seems very unlikely to me that this spec won't be updated eventually to match. The longer this stays in trunk, the more likely we'll get stuck unable to remove it due to compatibility concerns. Filing the spec bug is important of course.
Adam Barth
Comment 5 2011-12-26 13:26:45 PST
Comment on attachment 113884 [details] Patch Agreed. This is definitely the direction the platform is headed.
Dominic Cooney
Comment 6 2011-12-27 18:08:35 PST
Committed r103746.
Note You need to log in before you can comment on or make changes to this bug.