Bug 71700

Summary:

Web Inspector: Suggest box should consume enter key pressed event.

Product:

WebKit

Reporter:

Vsevolod Vlasov <vsevik>

Component:

Web Inspector (Deprecated)

Assignee:

Vsevolod Vlasov <vsevik>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, ossy, pfeldman, pmuellr, rik, timothy, yurys

Priority:

P2

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

71709

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	pfeldman: review+

Vsevolod Vlasov

Reported 2011-11-07 09:27:49 PST

Suggest box should consume enter key pressed event.

Attachments
Patch (3.16 KB, patch) 2011-11-07 09:33 PST, Vsevolod Vlasov	no flags	Details Formatted Diff Diff
Patch (4.69 KB, patch) 2011-11-07 12:05 PST, Vsevolod Vlasov	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Vsevolod Vlasov

Comment 1 2011-11-07 09:33:44 PST

Created attachment 113882 [details] Patch

Vsevolod Vlasov

Comment 2 2011-11-07 09:36:48 PST

Committed r99432: <http://trac.webkit.org/changeset/99432>

Csaba Osztrogonác

Comment 3 2011-11-07 11:04:54 PST

(In reply to comment #2) > Committed r99432: <http://trac.webkit.org/changeset/99432> I don't know how, but this patch made layout testing so so slow: - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/39429/steps/layout-test - http://build.webkit.org/builders/Chromium%20Linux%20Release%20%28Tests%29/builds/25702/steps/layout-test - http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34508/steps/layout-test Could you fix it ASAP or roll it out to make buildbots work?

Csaba Osztrogonác

Comment 4 2011-11-07 11:18:54 PST

It was rolled out: http://trac.webkit.org/changeset/99447

Vsevolod Vlasov

Comment 5 2011-11-07 12:05:25 PST

Created attachment 113905 [details] Patch

Vsevolod Vlasov

Comment 6 2011-11-07 12:35:33 PST

Committed r99458: <http://trac.webkit.org/changeset/99458>

Note You need to log in before you can comment on or make changes to this bug.