Bug 71697
| Summary: | build-webkit --install-headers no longer installs QtWebKit headers | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Andrew Wason <rectalogic> |
| Component: | WebKit Qt | Assignee: | Tor Arne Vestbø <vestbo> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | vestbo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 71222 | ||
Andrew Wason
Building webkit with:
cd /home/aw/Projects/foundation/webkit
Tools/Scripts/build-webkit --qt --debug --makeargs=-j20 --3d-canvas --3d-rendering --no-video --no-geolocation --no-netscape-plugin --install-headers=/home/aw/Projects/foundation/qt480/include --install-libs=/home/aw/Projects/foundation/qt480/lib
cd WebKitBuild/Debug
make && make install
no longer installs QtWebKit headers.
The relevant section of "make install" output seems to be:
[...]
make -f Makefile.QtWebKit.api install
make[2]: Entering directory `/home/aw/Projects/foundation/webkit/WebKitBuild/Debug/Source'
perl /home/aw/Projects/foundation/webkit/Tools/qmake/syncqt-4.8 -outdir /home/aw/Projects/foundation/webkit/WebKitBuild/Debug -separate-module QtWebKit:/home/aw/Projects/foundation/webkit:Source/WebKit/qt/Api
install -m 644 -p /home/aw/Projects/foundation/webkit/Tools/qmake/qt_webkit.pri /home/aw/Projects/foundation/qt480/mkspecs/modules/
install -m 755 -p "../lib/libQtWebKit.so.4.10.0" "/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so.4.10.0"
ln -f -s "libQtWebKit.so.4.10.0" "/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so"
ln -f -s "libQtWebKit.so.4.10.0" "/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so.4"
ln -f -s "libQtWebKit.so.4.10.0" "/home/aw/Projects/foundation/qt480/lib/libQtWebKit.so.4.10"
install -m 644 -p "../lib/libQtWebKit.prl" "/home/aw/Projects/foundation/qt480/lib/libQtWebKit.prl"
sed -e "s,/home/aw/Projects/foundation/webkit/WebKitBuild/Debug/lib,/home/aw/Projects/foundation/qt480/lib,g" "../lib/pkgconfig/QtWebKit.pc" >"/home/aw/Projects/foundation/qt480/lib/pkgconfig/QtWebKit.pc"
make[2]: Leaving directory `/home/aw/Projects/foundation/webkit/WebKitBuild/Debug/Source'
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Tor Arne Vestbø
Fixed in r99542
Andrew Wason
(In reply to comment #1)
> Fixed in r99542
The header files are installed now, but they are incorrect relative references.
e.g. in my case /home/aw/Projects/foundation/qt480/include/QtWebKit/QWebPage contains:
#include "qwebpage.h"
and /home/aw/Projects/foundation/qt480/include/QtWebKit/qwebpage.h contains:
#include "../../../../Source/WebKit/qt/Api/qwebpage.h"
which appears to be a broken reference to a file within my webkit source directory.
In file included from ../../../qt480/include/QtWebKit/QWebView:1,
from threadcrash.h:2,
from main.cpp:3:
../../../qt480/include/QtWebKit/qwebview.h:1:55: error: ../../../../Source/WebKit/qt/Api/qwebview.h: No such file or directory
Tor Arne Vestbø
Reopening
Tor Arne Vestbø
This prospective patch should fix it
https://gist.github.com/1352315
I'll land it tomorrow.
Andrew Wason
(In reply to comment #4)
> This prospective patch should fix it
>
> https://gist.github.com/1352315
Thanks, that fixes it.
Tor Arne Vestbø
Landed in r99832