Bug 71692

Summary: REGRESSION(r99409): Broke transitions/clip-transition.html
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: koivisto, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Andreas Kling 2011-11-07 08:29:25 PST 
Looks like I forgot to add some base class initializations in a couple of the CSSPrimitiveValue ctors. For shame.
Comment 1 Andreas Kling 2011-11-07 08:31:04 PST 
Created attachment 113872 [details]
Patch
Comment 2 Darin Adler 2011-11-07 10:54:01 PST 
Comment on attachment 113872 [details]
Patch

I guess this is OK. Seems quite inelegant though. Maybe that initializer has the wrong default?
Comment 3 Andreas Kling 2011-11-07 11:04:41 PST 
(In reply to comment #2)
> (From update of attachment 113872 [details])
> I guess this is OK. Seems quite inelegant though. Maybe that initializer has the wrong default?

I agree that it's not very pretty, but didn't bother making it much nicer since I'll be removing this way of constructing CSSValues for bug 71668 anyway.
Comment 4 Andreas Kling 2011-11-07 11:10:23 PST 
Committed r99444: <http://trac.webkit.org/changeset/99444>