Bug 71680 – [Qt][WK2] MiniBrowser should use urlFromUserInput()

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Zeno Albisser]

Currently MiniBrowser does nothing when an address with a missing http:// prefix is entered.
Using the urlFromUserInput() method this could be automatically completed.

[Zeno Albisser]

Created attachment 113861 [details]
patch for review.

[WebKit Review Bot]

Comment on attachment 113861 [details]
patch for review.

Rejecting attachment 113861 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/10332661

[Tor Arne Vestbø]

Comment on attachment 113861 [details]
patch for review.

let's try this again

[WebKit Review Bot]

Comment on attachment 113861 [details]
patch for review.

Rejecting attachment 113861 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/10333719

[Tor Arne Vestbø]

Is it barfing on my name? Or something else?

[Csaba Osztrogonác]

(In reply to comment #5)
> Is it barfing on my name? Or something else?

Yes, CQ doesn't like our name: https://bugs.webkit.org/show_bug.cgi?id=63452 ,
so it can't land patches reviewed by you or me. :(

[Simon Hausmann]

Comment on attachment 113861 [details]
patch for review.

Clearing flags on attachment: 113861

Committed r99527: <http://trac.webkit.org/changeset/99527>

[Simon Hausmann]

All reviewed patches have been landed.  Closing bug.

[Simon Hausmann]

(In reply to comment #6)
> (In reply to comment #5)
> > Is it barfing on my name? Or something else?
> 
> Yes, CQ doesn't like our name: https://bugs.webkit.org/show_bug.cgi?id=63452 ,
> so it can't land patches reviewed by you or me. :(

Weirdly enough webkit-patch land-from-bug <1234> works just fine (and worked for this bug, too :)

[Csaba Osztrogonác]

It broke WK2 build:

/usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x58d): error: undefined reference to 'vtable for Utils'
/usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x95d): error: undefined reference to 'vtable for Utils'


It might be an icremental build issue because of new build system.

[Simon Hausmann]

(In reply to comment #10)
> It broke WK2 build:
> 
> /usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x58d): error: undefined reference to 'vtable for Utils'
> /usr/bin/gold: obj/release/BrowserWindow.o: in function BrowserWindow::BrowserWindow(WindowOptions*):BrowserWindow.cpp(.text+0x95d): error: undefined reference to 'vtable for Utils'
> 
> 
> It might be an icremental build issue because of new build system.

Yeah, it is an incremental build issue. I touched the .pro file and then it all went fine on the bot.

[Csaba Osztrogonác]

I triggered a clean build on the bot and it works, so 
it is an incremental build bug. I filed a new bug report:
https://bugs.webkit.org/show_bug.cgi?id=71775