Bug 71679

Summary:

Don't use CSSOM's CSSValue.cssValueType internally in WebCore.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

CSS

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, japhet, macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Andreas Kling 2011-11-07 06:26:42 PST

This method is grainy and granular. We should use the more explicit isPrimitiveValue() and friends.
We'll need to add isInitialValue() and isInheritedValue() for this.
They will be temporarily virtual until <http://webkit.org/b/71666> kicks in.

Comment 1 Andreas Kling 2011-11-07 06:33:04 PST

Created attachment 113857 [details]
Patch

Comment 2 Darin Adler 2011-11-07 10:52:51 PST

Comment on attachment 113857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113857&action=review

> Source/WebCore/ChangeLog:3
> +        Don't use CSSOM's CSSValue.cssValueType internally in WebCore.

You should say why. I presume because it’s slow? Or maybe unclear?

Comment 3 Andreas Kling 2011-11-07 11:21:15 PST

Committed r99450: <http://trac.webkit.org/changeset/99450>