Bug 71641

Summary: InputType::fallbackValue and defaultValue should be const
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2011-11-06 15:35:06 PST
They should both be const so it could be used inside other const methods.
Attachments
Patch (8.83 KB, patch)
2011-11-06 15:38 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (8.88 KB, patch)
2011-11-06 17:46 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (8.89 KB, patch)
2011-11-06 17:53 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2011-11-06 15:38:14 PST
Created attachment 113809 [details] Patch
Kent Tamura
Comment 2 2011-11-06 17:13:49 PST
Comment on attachment 113809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113809&action=review > Source/WebCore/html/BaseCheckableInputType.h:51 > + virtual String fallbackValue() const; We had better add 'OVERRIDE' too. > Source/WebCore/html/ColorInputType.h:51 > + virtual String fallbackValue() const; ditto. > Source/WebCore/html/RangeInputType.h:70 > + virtual String fallbackValue() const; ditto. > Source/WebCore/html/ResetInputType.h:47 > + virtual String defaultValue() const; ditto. > Source/WebCore/html/SubmitInputType.h:49 > + virtual String defaultValue() const; ditto.
Keishi Hattori
Comment 3 2011-11-06 17:46:53 PST
Created attachment 113815 [details] Patch
Keishi Hattori
Comment 4 2011-11-06 17:48:23 PST
Comment on attachment 113815 [details] Patch Added OVERRIDE
Kent Tamura
Comment 5 2011-11-06 17:49:34 PST
Comment on attachment 113815 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113815&action=review > Source/WebCore/html/ResetInputType.h:47 > + virtual String defaultValue() const; We had better add 'OVERRIDE'
Keishi Hattori
Comment 6 2011-11-06 17:51:29 PST
Comment on attachment 113815 [details] Patch Missed that one. Fixing.
Keishi Hattori
Comment 7 2011-11-06 17:53:54 PST
Created attachment 113816 [details] Patch
WebKit Review Bot
Comment 8 2011-11-06 22:27:47 PST
Comment on attachment 113816 [details] Patch Clearing flags on attachment: 113816 Committed r99395: <http://trac.webkit.org/changeset/99395>
WebKit Review Bot
Comment 9 2011-11-06 22:27:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.