Bug 71627

Summary:

Web Inspector: introduce UserAgent override setting.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, caseq, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+
[IMAGE] Override unchecked	none
[IMAGE] Override checked	none
[IMAGE] Agent list	none
[IMAGE] Manual entry	none

Pavel Feldman

Reported 2011-11-06 10:43:36 PST

Patch to follow.

Attachments
Patch (18.16 KB, patch) 2011-11-06 10:47 PST, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
[IMAGE] Override unchecked (193.76 KB, image/png) 2011-11-06 10:47 PST, Pavel Feldman	no flags	Details
[IMAGE] Override checked (209.85 KB, image/png) 2011-11-06 10:48 PST, Pavel Feldman	no flags	Details
[IMAGE] Agent list (23.03 KB, image/png) 2011-11-06 10:48 PST, Pavel Feldman	no flags	Details
[IMAGE] Manual entry (208.58 KB, image/png) 2011-11-06 10:49 PST, Pavel Feldman	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-11-06 10:47:03 PST

Created attachment 113787 [details] Patch

Pavel Feldman

Comment 2 2011-11-06 10:47:54 PST

Created attachment 113788 [details] [IMAGE] Override unchecked

Pavel Feldman

Comment 3 2011-11-06 10:48:20 PST

Created attachment 113789 [details] [IMAGE] Override checked

Pavel Feldman

Comment 4 2011-11-06 10:48:47 PST

Created attachment 113790 [details] [IMAGE] Agent list

Pavel Feldman

Comment 5 2011-11-06 10:49:19 PST

Created attachment 113791 [details] [IMAGE] Manual entry

Yury Semikhatsky

Comment 6 2011-11-07 04:50:40 PST

Comment on attachment 113787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113787&action=review > Source/WebCore/inspector/front-end/SettingsScreen.js:64 > + p.appendChild(this._createUserActionControl()); _createUserA gent Control > Source/WebCore/inspector/front-end/SettingsScreen.js:240 > + ["Internet Explorer 9", "Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0"], Let's sort these options alphabetically. > Source/WebCore/inspector/front-end/SettingsScreen.js:247 > + ["Firefox 4 \u2014 Mac", "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1"], I'd suggest adding FF3 as well.

Pavel Feldman

Comment 7 2011-11-07 05:22:28 PST

Committed r99408: <http://trac.webkit.org/changeset/99408>

Note You need to log in before you can comment on or make changes to this bug.