Bug 71614

Summary: [GTK] Actually use the user_data arguments to gio async functions
Product: WebKit Reporter: Dan Winship <danw>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Actually use the user_data arguments to gio async functions none

Dan Winship
Reported 2011-11-05 16:25:58 PDT
see patch
Attachments
Actually use the user_data arguments to gio async functions (8.44 KB, patch)
2011-11-05 16:26 PDT, Dan Winship
no flags
Dan Winship
Comment 1 2011-11-05 16:26:47 PDT
Created attachment 113767 [details] Actually use the user_data arguments to gio async functions
WebKit Review Bot
Comment 2 2011-11-05 16:34:58 PDT
Comment on attachment 113767 [details] Actually use the user_data arguments to gio async functions Rejecting attachment 113767 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: fuzz 3. patching file Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp Hunk #4 succeeded at 486 with fuzz 2. Hunk #9 FAILED at 802. Hunk #10 succeeded at 840 (offset 1 line). Hunk #11 FAILED at 855. Hunk #12 succeeded at 886 (offset 7 lines). 2 out of 12 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10332332
Martin Robinson
Comment 3 2011-11-05 16:36:34 PDT
This patch may need to be rebaselined to the current master.
Dan Winship
Comment 4 2011-11-05 16:45:40 PDT
no, the bot just tried to commit them in the wrong order... you should be able to commit-queue+ it again after it commits 71613
WebKit Review Bot
Comment 5 2011-11-05 17:50:53 PDT
Comment on attachment 113767 [details] Actually use the user_data arguments to gio async functions Clearing flags on attachment: 113767 Committed r99364: <http://trac.webkit.org/changeset/99364>
WebKit Review Bot
Comment 6 2011-11-05 17:50:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.