Bug 71592

Summary: sqrtDouble and andnotDouble should be declared noreturn
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: JavaScriptCoreAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: psolanki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Pratik Solanki
Reported 2011-11-04 16:11:32 PDT
sqrtDouble and andnotDouble should be declared noreturn in debug builds since they just have ASSERT_NOT_REACHED() in them.
Attachments
Patch (1.39 KB, patch)
2011-11-04 16:12 PDT, Pratik Solanki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-11-04 16:12:45 PDT
Created attachment 113726 [details] Patch
WebKit Review Bot
Comment 2 2011-11-04 16:51:41 PDT
Comment on attachment 113726 [details] Patch Clearing flags on attachment: 113726 Committed r99333: <http://trac.webkit.org/changeset/99333>
WebKit Review Bot
Comment 3 2011-11-04 16:51:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.