Bug 71580

Summary: [chromium] Re-name the original scissorRect to clipRect
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Layout and RenderingAssignee: Shawn Singh <shawnsingh>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67341    
Attachments:
Description Flags
Patch none

Shawn Singh
Reported 2011-11-04 12:04:10 PDT
In layers and render surfaces of chromium, there is a scissorRect that is maintained for clipping/masking. It is only used for this purpose, and with upcoming scissor optimization, it is appropriate to re-name this original scissorRect to clipRect.
Attachments
Patch (27.44 KB, patch)
2011-11-04 14:00 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2011-11-04 14:00:25 PDT
Created attachment 113708 [details] Patch
Adrienne Walker
Comment 2 2011-11-04 14:06:56 PDT
That unofficially looks good to me. I think this will definitely make it easier to differentiate the existing static clipping from the new scissoring feature.
WebKit Review Bot
Comment 3 2011-11-04 15:16:41 PDT
Comment on attachment 113708 [details] Patch Clearing flags on attachment: 113708 Committed r99327: <http://trac.webkit.org/changeset/99327>
WebKit Review Bot
Comment 4 2011-11-04 15:16:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.