Bug 71576

Summary: [GTK] Frame flattening tests are super-flaky after switching to backing store-based painting
Product: WebKit Reporter: Zan Dobersek <zan>
Component: Tools / TestsAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, koivisto, mrobinson, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Zan Dobersek
Reported 2011-11-04 11:16:21 PDT
Tests in fast/frames/flattening became very unstable after backing store was introduced for painting in the GTK port (r98827). There are occasions when the tests pass without anomalies, but most often there appear some flaky tests and also tests that fail even on retry. Martin suggests skipping these tests while he's working on polishing the whole thing. Patch incoming.
Attachments
Patch (1.48 KB, patch)
2011-11-04 11:26 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (22.98 KB, patch)
2011-11-05 17:23 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2011-11-04 11:26:10 PDT
Created attachment 113684 [details] Patch
Martin Robinson
Comment 2 2011-11-05 16:46:07 PDT
Comment on attachment 113684 [details] Patch Clearing flags on attachment: 113684 Committed r99360: <http://trac.webkit.org/changeset/99360>
Martin Robinson
Comment 3 2011-11-05 16:49:26 PDT
The issue seems to be that many frame flattening tests wait until the <body onload> event on the body to call layoutTestController.setFrameFlatteningEnabled(true). Toggling the frame flattening setting does not trigger a relayout. If the first layout happens before <body onload> the page will be in the incorrect state. I'm uploading a patch that toggles the setting immediately instead of waiting until onload. This seems to remove the flakiness on my machine.
Martin Robinson
Comment 4 2011-11-05 17:23:57 PDT
Created attachment 113769 [details] Patch
Martin Robinson
Comment 5 2011-11-05 17:34:59 PDT
Comment on attachment 113769 [details] Patch Clearing flags on attachment: 113769 Committed r99361: <http://trac.webkit.org/changeset/99361>
Martin Robinson
Comment 6 2011-11-05 17:35:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.