Summary: | [NRWT] Make single_test_runner aware of test_input.ref_file. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hayato Ito <hayato> | ||||||
Component: | Tools / Tests | Assignee: | Hayato Ito <hayato> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dpranke, ojan, rniwa, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 66295 | ||||||||
Attachments: |
|
Description
Hayato Ito
2011-11-04 10:12:57 PDT
Created attachment 113677 [details]
WIP.
This WIP patch should work on the top of the patch in bug 66937, though there remains an issue of displaying the result. See bug 71574. I'll add tests later. Comment on attachment 113677 [details] WIP. Does this break the existing reftests? If we can keep this working, then we can commit this patch without waiting for bug 66837 to be resolved. Eventually, whether we use manifests or link elements, we can populate the test_input element appropriately to make this code work. (In reply to comment #3) > (From update of attachment 113677 [details]) > Does this break the existing reftests? If we can keep this working, then we can commit this patch without waiting for bug 66837 to be resolved. Eventually, whether we use manifests or link elements, we can populate the test_input element appropriately to make this code work. I don't think it makes sense to land this patch unless we're parsing reftest.list. Since we don't need to pass any information from manager to single_test_runner if we're parsing link element. (In reply to comment #3) > (From update of attachment 113677 [details]) > Does this break the existing reftests? If we can keep this working, then we can commit this patch without waiting for bug 66837 to be resolved. Eventually, whether we use manifests or link elements, we can populate the test_input element appropriately to make this code work. Yes, this patch is intended to work on either we use manifest file or link elements. I assumed that caller should pass reference file name. It is possible to make this patch not break existing reftests and independent of bug 66837. Created attachment 114202 [details]
aware test_input.ref_file
I'll land this patch. The patch now works without bug 66837 and doesn't not break existing reftests. I'll address bug 71574, which also doesn't affect existing reftests, later. Committed r99651: <http://trac.webkit.org/changeset/99651> |