Bug 71563

Summary: [chromium] Use Chromium's copy of libWebKitSystemInterfaceLeopard.a
Product: WebKit Reporter: Robert Sesek <rsesek>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, mark, playmobil, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: Unspecified   
URL: http://code.google.com/p/chromium/issues/detail?id=101387
Attachments:
Description Flags
Patch none

Robert Sesek
Reported 2011-11-04 08:24:52 PDT
WebKit is going to remove it soon, and the chromium WebKit port should pull in Chromium's copy via DEPS and link against it rather than the one that will be removed.
Attachments
Patch (9.71 KB, patch)
2011-11-04 09:37 PDT, Robert Sesek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Sesek
Comment 1 2011-11-04 09:37:46 PDT
Created attachment 113668 [details] Patch
Adam Barth
Comment 2 2011-11-04 10:05:47 PDT
Comment on attachment 113668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113668&action=review > Source/WebCore/WebCore.gyp/WebCore.gyp:175 > + 'libjpeg_gyp_path': '../../WebKit/chromium/third_party/libjpeg_turbo/libjpeg.gyp', Why is this special cased?
Robert Sesek
Comment 3 2011-11-04 10:35:58 PDT
Comment on attachment 113668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113668&action=review >> Source/WebCore/WebCore.gyp/WebCore.gyp:175 >> + 'libjpeg_gyp_path': '../../WebKit/chromium/third_party/libjpeg_turbo/libjpeg.gyp', > > Why is this special cased? Mark says it's problematic to reference variables in the same scope in which they're defined.
Adam Barth
Comment 4 2011-11-04 10:39:52 PDT
Comment on attachment 113668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113668&action=review >>> Source/WebCore/WebCore.gyp/WebCore.gyp:175 >>> + 'libjpeg_gyp_path': '../../WebKit/chromium/third_party/libjpeg_turbo/libjpeg.gyp', >> >> Why is this special cased? > > Mark says it's problematic to reference variables in the same scope in which they're defined. My point is we have lots of dependencies on things in chromium/third_party, but we don't list them here. We just use the chromium_src_dir to find them. It's not clear to me why libjpeg_turbo is different that those other dependencies.
Robert Sesek
Comment 5 2011-11-04 10:41:10 PDT
Comment on attachment 113668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113668&action=review >>>> Source/WebCore/WebCore.gyp/WebCore.gyp:175 >>>> + 'libjpeg_gyp_path': '../../WebKit/chromium/third_party/libjpeg_turbo/libjpeg.gyp', >>> >>> Why is this special cased? >> >> Mark says it's problematic to reference variables in the same scope in which they're defined. > > My point is we have lots of dependencies on things in chromium/third_party, but we don't list them here. We just use the chromium_src_dir to find them. It's not clear to me why libjpeg_turbo is different that those other dependencies. Oh, that I do not know. It was here originally and I'm not sure why it's only defined when not building inside Chromium.
Adam Barth
Comment 6 2011-11-04 10:42:38 PDT
Yeah, I see that you're just moving it. It just caught my eye reading through the patch.
WebKit Review Bot
Comment 7 2011-11-04 12:12:34 PDT
Comment on attachment 113668 [details] Patch Clearing flags on attachment: 113668 Committed r99308: <http://trac.webkit.org/changeset/99308>
WebKit Review Bot
Comment 8 2011-11-04 12:12:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.