Bug 71547

Summary: [GTK] Disable VIDEO_TRACK for now
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, eric.carlson, gustavo, pnormand, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch gustavo: review+, gustavo: commit-queue-

Philippe Normand
Reported 2011-11-04 01:52:12 PDT
This feature is still in development and should not be enabled by default. Especially in the released tarballs.
Attachments
proposed patch (8.69 KB, patch)
2011-11-04 01:56 PDT, Philippe Normand 		gustavo: review+
gustavo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2011-11-04 01:56:24 PDT
Created attachment 113636 [details] proposed patch
Gustavo Noronha (kov)
Comment 2 2011-11-04 02:19:00 PDT
Comment on attachment 113636 [details] proposed patch Attachment 113636 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10313107
Philippe Normand
Comment 3 2011-11-04 07:30:11 PDT
A clean build is needed I'm afraid :( Can we sync up (as usual) with kov if we land this? :)
Eric Carlson
Comment 4 2011-11-04 07:38:16 PDT
(In reply to comment #0) > This feature is still in development and should not be enabled by default. Especially in the released tarballs. Thank you!
Anna Cavender
Comment 5 2011-11-04 08:09:23 PDT
(In reply to comment #4) > (In reply to comment #0) > > This feature is still in development and should not be enabled by default. Especially in the released tarballs. > > Thank you! Yes, thank you!
Martin Robinson
Comment 6 2011-11-04 08:23:35 PDT
Comment on attachment 113636 [details] proposed patch Would it make sense to disable this in configure.ac and enable it via build-webkit so that we still get test coverage?
Philippe Normand
Comment 7 2011-11-04 08:30:22 PDT
(In reply to comment #6) > (From update of attachment 113636 [details]) > Would it make sense to disable this in configure.ac and enable it via build-webkit so that we still get test coverage? Yes it would. But then we'd need a new option for this in build-webkit as it's not there (or I missed it) :)
Philippe Normand
Comment 8 2011-11-04 09:11:05 PDT
Committed r99285: <http://trac.webkit.org/changeset/99285>
Note You need to log in before you can comment on or make changes to this bug.