Bug 71547

Summary: [GTK] Disable VIDEO_TRACK for now
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annacc, eric.carlson, gustavo, pnormand, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch gustavo: review+, gustavo: commit-queue-

Description Philippe Normand 2011-11-04 01:52:12 PDT 
This feature is still in development and should not be enabled by default. Especially in the released tarballs.
Comment 1 Philippe Normand 2011-11-04 01:56:24 PDT 
Created attachment 113636 [details]
proposed patch
Comment 2 Gustavo Noronha (kov) 2011-11-04 02:19:00 PDT 
Comment on attachment 113636 [details]
proposed patch

Attachment 113636 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10313107
Comment 3 Philippe Normand 2011-11-04 07:30:11 PDT 
A clean build is needed I'm afraid :(
Can we sync up (as usual) with kov if we land this? :)
Comment 4 Eric Carlson 2011-11-04 07:38:16 PDT 
(In reply to comment #0)
> This feature is still in development and should not be enabled by default. Especially in the released tarballs.

Thank you!
Comment 5 Anna Cavender 2011-11-04 08:09:23 PDT 
(In reply to comment #4)
> (In reply to comment #0)
> > This feature is still in development and should not be enabled by default. Especially in the released tarballs.
> 
> Thank you!

Yes, thank you!
Comment 6 Martin Robinson 2011-11-04 08:23:35 PDT 
Comment on attachment 113636 [details]
proposed patch

Would it make sense to disable this in configure.ac and enable it via build-webkit so that we still get test coverage?
Comment 7 Philippe Normand 2011-11-04 08:30:22 PDT 
(In reply to comment #6)
> (From update of attachment 113636 [details])
> Would it make sense to disable this in configure.ac and enable it via build-webkit so that we still get test coverage?

Yes it would. But then we'd need a new option for this in build-webkit as it's not there (or I missed it) :)
Comment 8 Philippe Normand 2011-11-04 09:11:05 PDT 
Committed r99285: <http://trac.webkit.org/changeset/99285>