Bug 71546

Summary: [Qt] Remove ENABLE_SQLITE from qmake files
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
hausmann: review-, webkit-ews: commit-queue-
Patch none

Patrick R. Gansterer
Reported 2011-11-04 01:51:40 PDT
[Qt] Remove ENABLE_SQLITE from qmake files
Attachments
Patch (5.36 KB, patch)
2011-11-04 01:55 PDT, Patrick R. Gansterer 		hausmann: review-
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (5.63 KB, patch)
2011-11-04 12:58 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-11-04 01:55:55 PDT
Created attachment 113635 [details] Patch
Early Warning System Bot
Comment 2 2011-11-04 02:13:11 PDT
Comment on attachment 113635 [details] Patch Attachment 113635 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10310098
Simon Hausmann
Comment 3 2011-11-04 12:21:08 PDT
Comment on attachment 113635 [details] Patch Thanks! I think the patch is correct in principle, but it doesn't compile like that anymore :(. We did a bunch of changes in the build system today that will require this change to adjusted to the new locations. So take the r- like this: Correct patch, but needs adaption against new .pri/.pro files before landing :)
Patrick R. Gansterer
Comment 4 2011-11-04 12:58:13 PDT
Created attachment 113701 [details] Patch
Simon Hausmann
Comment 5 2011-11-04 13:41:58 PDT
Comment on attachment 113701 [details] Patch r=me. Thanks Patrick!
WebKit Review Bot
Comment 6 2011-11-04 14:00:28 PDT
Comment on attachment 113701 [details] Patch Clearing flags on attachment: 113701 Committed r99317: <http://trac.webkit.org/changeset/99317>
WebKit Review Bot
Comment 7 2011-11-04 14:00:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.