Bug 71537

Summary: Canvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
Product: WebKit Reporter: Ben Wells <benwells>
Component: New BugsAssignee: Ben Wells <benwells>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, mdelaney7, rniwa, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71672    
Attachments:
Description Flags
Patch none

Ben Wells
Reported 2011-11-03 20:35:51 PDT
Canvas drawImage(canvas) with SourceIn, DestinationIn, SourceOut, DestinationAtop and Copy have errors
Attachments
Patch (65.65 KB, patch)
2011-11-03 20:38 PDT, Ben Wells 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Wells
Comment 1 2011-11-03 20:38:43 PDT
Created attachment 113616 [details] Patch
Kenneth Russell
Comment 2 2011-11-04 13:42:16 PDT
Comment on attachment 113616 [details] Patch senorblanco, can you review this?
Stephen White
Comment 3 2011-11-04 13:56:27 PDT
Comment on attachment 113616 [details] Patch Code looks good. I'm just going to trust you on the test, since side-by-side diff failed me miserably here. r=me
Ben Wells
Comment 4 2011-11-04 16:33:13 PDT
(In reply to comment #3) > (From update of attachment 113616 [details]) > Code looks good. I'm just going to trust you on the test, since side-by-side diff failed me miserably here. r=me Yeah the change wasn't really diff friendly. I pulled out most of the test code for drawImage(image) and put it into a separate file as the drawImage(canvas) and drawImage(image) tests can share almost everything (especially expected pixel values which are a pain extract). A matching fix to drawImage(videoElement) will be coming along next week and will hopefully use the same shared test code.
WebKit Review Bot
Comment 5 2011-11-04 19:00:09 PDT
Comment on attachment 113616 [details] Patch Clearing flags on attachment: 113616 Committed r99349: <http://trac.webkit.org/changeset/99349>
WebKit Review Bot
Comment 6 2011-11-04 19:00:13 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 7 2011-11-06 13:08:34 PST
It appears that the test added by this patch has been failing on GTK and Qt: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcanvas%2Fcanvas-composite-canvas.html
Ben Wells
Comment 8 2011-11-06 14:27:56 PST
(In reply to comment #7) > It appears that the test added by this patch has been failing on GTK and Qt: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=fast%2Fcanvas%2Fcanvas-composite-canvas.html OK, the same thing happened with the matching test for drawImage(image). I'll add bugs for Qt and GTK and skip this test on those platforms.
Note You need to log in before you can comment on or make changes to this bug.