Bug 71523

Summary: De-virtualize JSObject::getOwnPropertyDescriptor
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70960    
Attachments:
Description Flags
Patch
none
Patch sam: review+

Mark Hahnenberg
Reported 2011-11-03 17:04:35 PDT
We're de-virtualizing JSObject. defineOwnPropertyDescriptor is a virtual method in JSObject. Thus, we need to de-virtualize defineOwnPropertyDescriptor. We'll put it in the MethodTable.
Attachments
Patch (151.73 KB, patch)
2011-11-04 14:21 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (151.76 KB, patch)
2011-11-04 14:37 PDT, Mark Hahnenberg 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-04 14:21:12 PDT
Created attachment 113713 [details] Patch
Mark Hahnenberg
Comment 2 2011-11-04 14:37:51 PDT
Created attachment 113716 [details] Patch
Sam Weinig
Comment 3 2011-11-08 16:18:25 PST
Comment on attachment 113716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113716&action=review > Source/JavaScriptCore/runtime/StringObject.h:33 > + virtual ~StringObject(); We tend to use a dummy virtual function (called dummyVirtual()) to anchor instead of the destructor. > Source/WebCore/bridge/runtime_method.h:40 > + ~RuntimeMethod(); Same here.
Mark Hahnenberg
Comment 4 2011-11-09 13:09:55 PST
Committed r99754: <http://trac.webkit.org/changeset/99754>
Note You need to log in before you can comment on or make changes to this bug.