Summary: | Remove RequiresAllArguments | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Erik Arvidsson <arv> | ||||
Component: | WebCore JavaScript | Assignee: | Erik Arvidsson <arv> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, japhet, ojan, pilgrim, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Erik Arvidsson
2011-11-03 13:45:12 PDT
Can we test these interfaces in other browsers? Perhaps we're actually supposed to raise an exception in these cases. For example, I'd be surprised if this goofy behavior was required for WebSocket. Firefox 8 throws for all of these when wrong number of arguments are provided IE9 treats missing arguments as 0 for all the window methods. IE9 throws "argument is not optional" for missing arguments for setData. Based on this I think we are pretty safe to remove RequiresAllArguments and change the window methods to [Optional=CallWithDefaultValue] Created attachment 114760 [details]
Patch
Sounds great. Comment on attachment 114760 [details] Patch Clearing flags on attachment: 114760 Committed r100163: <http://trac.webkit.org/changeset/100163> All reviewed patches have been landed. Closing bug. |