Bug 71483

Summary: REGRESSION (r99076): Pasting into password fields is broken
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Critical CC: darin, enrica, rniwa
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: data:text/html,%3Cinput%20type=password%3E
Attachments:
Description Flags
fixes the bug
none
Made a slight tweak to the test darin: review+

Alexey Proskuryakov
Reported 2011-11-03 10:23:18 PDT
When you paste into any password field, its value becomes all bullets. That includes not just rendering (which would be correct), but element.value in DOM, and submitted form data.
Attachments
fixes the bug (4.60 KB, patch)
2011-11-03 12:12 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Made a slight tweak to the test (4.60 KB, patch)
2011-11-03 13:51 PDT, Ryosuke Niwa 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-11-03 10:26:16 PDT
Drag&drop is also broken in the same way.
Ryosuke Niwa
Comment 2 2011-11-03 12:12:23 PDT
Created attachment 113538 [details] fixes the bug
Ryosuke Niwa
Comment 3 2011-11-03 13:51:44 PDT
Created attachment 113555 [details] Made a slight tweak to the test
Darin Adler
Comment 4 2011-11-03 13:54:15 PDT
Comment on attachment 113555 [details] Made a slight tweak to the test View in context: https://bugs.webkit.org/attachment.cgi?id=113555&action=review > Source/WebCore/editing/TextIterator.h:46 > + TextIteratorEmitsOriginalText = 1 << 8 Why 8 instead of 5?
Ryosuke Niwa
Comment 5 2011-11-03 13:55:52 PDT
Comment on attachment 113555 [details] Made a slight tweak to the test View in context: https://bugs.webkit.org/attachment.cgi?id=113555&action=review >> Source/WebCore/editing/TextIterator.h:46 > > Why 8 instead of 5? Oh oops, I was thinking they were bit flags but apparently not. Will fix.
Ryosuke Niwa
Comment 6 2011-11-03 13:59:15 PDT
Hm... odd. I somehow didn't get "review granted" or comment emails from Bugzilla for his bug.
Ryosuke Niwa
Comment 7 2011-11-03 21:52:08 PDT
Committed r99262: <http://trac.webkit.org/changeset/99262>
Note You need to log in before you can comment on or make changes to this bug.