Bug 7148

Summary: Add drag and drop support to DumpRenderTree
Product: WebKit Reporter: Justin Garcia <justin.garcia>
Component: HTML EditingAssignee: Justin Garcia <justin.garcia>
Status: RESOLVED FIXED    
Severity: Normal CC: vicki
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch
none
patch darin: review-

Justin Garcia
Reported 2006-02-08 21:33:38 PST
It would be sweet.
Attachments
patch (22.32 KB, patch)
2006-02-09 03:22 PST, Justin Garcia 		no flags
DetailsFormatted DiffDiff
patch (20.44 KB, patch)
2006-02-09 03:23 PST, Justin Garcia 		darin: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Garcia
Comment 1 2006-02-09 03:22:33 PST
Created attachment 6362 [details] patch First cut. Works but I'd like comments. Setting the review flag.
Justin Garcia
Comment 2 2006-02-09 03:23:56 PST
Created attachment 6363 [details] patch oops wrong patch
Darin Adler
Comment 3 2006-02-10 08:30:22 PST
Comment on attachment 6363 [details] patch If a page is not a test in itself, you should put it in a resources subdirectory. That way the test script won't generate separate results for the test. If updateFocusState is now SPI, can we remove the _setWindowHasFocus: and _setDisplaysWithFocusAttributes: SPI? Also, why doesn't setDisplaysWithFocusAttributes: call updateFocusState? I don't think it's a good technique to have DumpRenderTree pose as WebHTMLView. We do that with AppKit classes because we don't have any alternative, but since DumpRenderTree and WebHTMLView are both part of WebKit, we can expose whatever we need as SPI or API instead of doing the "pose" thing. For example, we could have an SPI delegate method on the UI delegate to start drags. But I suppose we could land it with the posing if that's significantly easier to write. This otherwise looks pretty good.
Justin Garcia
Comment 4 2006-02-20 14:56:31 PST
I landed a fix for this.
Note You need to log in before you can comment on or make changes to this bug.