Bug 71430

Summary: De-virtualize JSObject::hasInstance
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70960    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Mark Hahnenberg
Reported 2011-11-02 18:30:19 PDT
We're de-virtualizing JSObject. hasInstance is a virtual method in JSObject. Thus, we need to de-virtualize hasInstance. We'll put it in the MethodTable.
Attachments
Patch (13.67 KB, patch)
2011-11-03 11:19 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (13.50 KB, patch)
2011-11-03 13:33 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (13.54 KB, patch)
2011-11-04 12:03 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2011-11-03 11:19:18 PDT
Created attachment 113527 [details] Patch
Mark Hahnenberg
Comment 2 2011-11-03 13:33:07 PDT
Created attachment 113549 [details] Patch
WebKit Review Bot
Comment 3 2011-11-03 15:40:57 PDT
Comment on attachment 113549 [details] Patch Clearing flags on attachment: 113549 Committed r99238: <http://trac.webkit.org/changeset/99238>
WebKit Review Bot
Comment 4 2011-11-03 15:41:01 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 5 2011-11-03 23:48:45 PDT
It made fast/js/function-bind.html crash on SL, GTK and on Qt: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28Tests%29/r99262%20%2834441%29/fast/js/function-bind-crash-log.txt
Csaba Osztrogonác
Comment 6 2011-11-04 00:37:18 PDT
Sorry, but I had to roll this patch out to make buildbot happier: http://trac.webkit.org/changeset/99264 Could you check what happened, please?
Mark Hahnenberg
Comment 7 2011-11-04 12:03:56 PDT
Created attachment 113694 [details] Patch
WebKit Review Bot
Comment 8 2011-11-04 13:37:49 PDT
Comment on attachment 113694 [details] Patch Clearing flags on attachment: 113694 Committed r99312: <http://trac.webkit.org/changeset/99312>
WebKit Review Bot
Comment 9 2011-11-04 13:37:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.