Bug 71374

Summary: Remove initCloseEvent method
Product: WebKit Reporter: Dominic Cooney <dominicc>
Component: DOMAssignee: Dominic Cooney <dominicc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68791    
Attachments:
Description Flags
Patch
none
Patch none

Dominic Cooney
Reported 2011-11-02 10:14:15 PDT
The CloseEvent.initCloseEvent method was removed from the WebSockets spec; it has been replaced with a constructor: <http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#closeevent> Code Search doesn't show any uses of this method <http://codesearch.google.com/#search/&q=initCloseEvent%20lang:js&type=cs>. We should remove it.
Attachments
Patch (8.10 KB, patch)
2011-11-02 11:09 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Patch (10.05 KB, patch)
2011-11-05 15:04 PDT, Dominic Cooney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominic Cooney
Comment 1 2011-11-02 11:09:49 PDT
Created attachment 113338 [details] Patch
Ojan Vafai
Comment 2 2011-11-02 11:28:13 PDT
Comment on attachment 113338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113338&action=review > Source/WebCore/websockets/CloseEvent.h:63 > void initCloseEvent(const AtomicString& type, bool canBubble, bool cancelable, bool wasClean, unsigned short code, const String& reason) Can we move this into the CloseEvent constructor and get rid of the canBubble/cancelable arguments since they are always false in the one place initCloseEvent is currently called? If there's a reason this is especially complicated, I'm OK with the patch as is and I'll r+ it. For now r-.
Dominic Cooney
Comment 3 2011-11-05 15:04:48 PDT
Created attachment 113763 [details] Patch
WebKit Review Bot
Comment 4 2011-11-07 10:05:07 PST
Comment on attachment 113763 [details] Patch Clearing flags on attachment: 113763 Committed r99438: <http://trac.webkit.org/changeset/99438>
WebKit Review Bot
Comment 5 2011-11-07 10:05:12 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.