Summary: | Remove initCloseEvent method | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dominic Cooney <dominicc> | ||||||
Component: | DOM | Assignee: | Dominic Cooney <dominicc> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, ojan, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 68791 | ||||||||
Attachments: |
|
Description
Dominic Cooney
2011-11-02 10:14:15 PDT
Created attachment 113338 [details]
Patch
Comment on attachment 113338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113338&action=review > Source/WebCore/websockets/CloseEvent.h:63 > void initCloseEvent(const AtomicString& type, bool canBubble, bool cancelable, bool wasClean, unsigned short code, const String& reason) Can we move this into the CloseEvent constructor and get rid of the canBubble/cancelable arguments since they are always false in the one place initCloseEvent is currently called? If there's a reason this is especially complicated, I'm OK with the patch as is and I'll r+ it. For now r-. Created attachment 113763 [details]
Patch
Comment on attachment 113763 [details] Patch Clearing flags on attachment: 113763 Committed r99438: <http://trac.webkit.org/changeset/99438> All reviewed patches have been landed. Closing bug. |