Summary: | [GTK] Add support for javascript dialogs in WebKit2 GTK+ API | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | gustavo, pnormand, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | 69753 | ||||||
Bug Blocks: | 71447 | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2011-11-02 07:14:21 PDT
Created attachment 113315 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 113315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113315&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:343 > + * Emitted when JavaScript code calls <function>alert</function>. If the alert -> window.alert > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:392 > + * signal is not handled a message dialog with Ok and Cancel buttons and Ok -> OK > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:109 > + htmlString = g_strdup_printf(htmlOnLoadFormat, "self.close();"); > + else if (g_str_equal(path, "/javascript_alert")) { > + GOwnPtr<char> alertDialogMessage(g_strdup_printf("alert('%s')", kAlertDialogMessage)); > + htmlString = g_strdup_printf(htmlOnLoadFormat, alertDialogMessage.get()); > + } else if (g_str_equal(path, "/javascript_confirm")) { > + GOwnPtr<char> alertDialogMessage(g_strdup_printf(jsConfirmFormat, kConfirmDialogMessage)); Could you skip soup server here again and just load a string? > Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp:247 > + g_main_loop_run(test->m_mainLoop); It's a bit odd that the fixture takes care of ending the main loop, but the test takes care of running it. Maybe you could add a method to the fixture like: runMainLoopUntilAlertDialog. Committed r102675: <http://trac.webkit.org/changeset/102675> |