Bug 71358 – JSC: Remove startPosition from SourceProvider, convert firstLine into TextPosition in SourceCode.

• Component: JavaScriptCore
• Status: RESOLVED INVALID

[Pavel Feldman]

Oliver suggested that SourceProvider should not be position aware, JSC should manage positions in the SourceCode.

[Pavel Feldman]

Created attachment 113309 [details]
Patch

[WebKit Review Bot]

Comment on attachment 113309 [details]
Patch

Attachment 113309 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10257270

New failing tests:
inspector/debugger/linkifier.html

[Yury Semikhatsky]

Comment on attachment 113309 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113309&action=review

> Source/JavaScriptCore/ChangeLog:56
> +        Web Inspector: [JSC] remove startPosition from SourceProvider,

Remove the second entry.

> Source/JavaScriptCore/debugger/Debugger.cpp:62
> +        m_debugger->sourceParsed(iter->second, *iter->first, -1, UString());

This should be called once per script source, not for each function in it and position should be the origin of that script.

> Source/JavaScriptCore/parser/ASTBuilder.h:257
> +    ExpressionNode* createFunctionExpr(int lineNumber, const Identifier* name, FunctionBodyNode* body, ParameterNode* parameters, int openBracePos, int closeBracePos, int bodyStartLine, int bodyStartColumn, int bodyEndLine)

Consider using TextPosition.