Bug 7125 – remove frame, renderer and completed flag from ChildFrame, make Frame track these

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Maciej Stachowiak]

This patch removes pretty much all remaining interesting content from ChildFrame, and splits frames and plugins more thoroughly. <object> tags containing html now act more like frames.

[Maciej Stachowiak]

Created attachment 6319 [details]
the patch

[Maciej Stachowiak]

Comment on attachment 6319 [details]
the patch

Eric reviewed this.

[Alexey Proskuryakov]

fast/dom/HTMLObjectElement/object-as-frame.html fails for me:

-PASS window.frames[1].location.toString() is "data:text/html,Updated contents of object"
+FAIL window.frames[1].location.toString() should be data:text/html,Updated contents of object. Was data:text/html,New contents of frame

LEAK: 51 RenderObject
LEAK: 63 NodeImpl
LEAK: 3 Frame
LEAK: 526 KJS::Node

Not reopening, because the bug was not closed yet, even though the patch has been landed.

(In reply to comment #3)
> fast/dom/HTMLObjectElement/object-as-frame.html fails for me:
> 
> -PASS window.frames[1].location.toString() is "data:text/html,Updated contents
> of object"
> +FAIL window.frames[1].location.toString() should be data:text/html,Updated
> contents of object. Was data:text/html,New contents of frame

I can confirm that the test is failing as of r12654, but as Alexey said on IRC, only on a dual-processor machine with both processors enabled. If I disable one of the processors, the test passes.

[Maciej Stachowiak]

Only fails on dual processors - that means a likely race condition.

[Alexey Proskuryakov]

Opened bug 7142 to track the test failure.