Bug 71232

Summary: [chromium] Calling methods of WebFontImpl causes assertions
Product: WebKit Reporter: yzshen
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, msaboff, webkit.review.bot, yzshen
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

yzshen
Reported 2011-10-31 12:33:54 PDT
Some of the methods in WebKit/chromium/src/WebFontImpl.{h,cpp} should use FontCachePurgePreventer, so that they won't trigger assertions in FontCache::getCachedFontData(). I will upload a patch very soon.
Attachments
Patch (2.26 KB, patch)
2011-10-31 13:05 PDT, yzshen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
yzshen
Comment 1 2011-10-31 13:05:53 PDT
Created attachment 113074 [details] Patch
Michael Saboff
Comment 2 2011-10-31 13:56:32 PDT
Although not a Chromium expert, these look right.
James Robinson
Comment 3 2011-10-31 14:20:16 PDT
When are these calls failing? Is it possible to construct a test?
yzshen
Comment 4 2011-10-31 15:01:11 PDT
All these calls are possible to reach FontCache::getCachedFontData(), which requires a FontCachePurgePreventer on the stack. I talked with Michael (who is the author of FontCachePurgePreventer and CC-ed in this bug) and we agreed that this was the correct way to fix the issue. But unfortunately I don't know much about how to create tests for it.
Michael Saboff
Comment 5 2011-10-31 15:10:54 PDT
Although not a test per se, there is an ASSERT that will fail in the case that a FontCachePurgePreventer is not active somewhere in the call chain when a fallback font is allocated.
James Robinson
Comment 6 2011-10-31 15:15:29 PDT
Comment on attachment 113074 [details] Patch OK, these look fine to me as well. Thanks for the information.
yzshen
Comment 7 2011-10-31 15:19:31 PDT
Thanks for your help, James and Michael!
WebKit Review Bot
Comment 8 2011-10-31 17:27:49 PDT
Comment on attachment 113074 [details] Patch Clearing flags on attachment: 113074 Committed r98921: <http://trac.webkit.org/changeset/98921>
WebKit Review Bot
Comment 9 2011-10-31 17:27:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.