Bug 71206

Summary:

WTF::StringImpl::create(const char*, unsigned) calls itself

Product:

WebKit

Reporter:

Xianzhu Wang <wangxianzhu>

Component:

Web Template Framework

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, ggaren, gregsimon, msaboff, rniwa, sullivan, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	rniwa: review+
patch v2	none

Xianzhu Wang

Reported 2011-10-30 23:50:36 PDT

Now WTF::StringImpl::create(const char*, unsigned) is: ALWAYS_INLINE static PassRefPtr<StringImpl> create(const char* s, unsigned length) { return create(s, length); }; which is an infinite recursion.

Attachments
patch (1.69 KB, patch) 2011-10-30 23:59 PDT, Xianzhu Wang	rniwa: review+	Details Formatted Diff Diff
patch v2 (1.87 KB, patch) 2011-10-31 00:16 PDT, Xianzhu Wang	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2011-10-30 23:58:05 PDT

I think it meant to be create(reinterpret_cast<const LChar*>(s), length).

Xianzhu Wang

Comment 2 2011-10-30 23:59:30 PDT

Created attachment 113016 [details] patch

Ryosuke Niwa

Comment 3 2011-10-31 00:00:44 PDT

Comment on attachment 113016 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=113016&action=review > Source/JavaScriptCore/ChangeLog:5 > + It'll be nice if you explained what was wrong with the existing code and what you fixed.

Ryosuke Niwa

Comment 4 2011-10-31 00:01:16 PDT

In fact, I suggest you rename the bug title to something like "StringImpl::create(const char*, unsigned) calls itself"

Xianzhu Wang

Comment 5 2011-10-31 00:16:32 PDT

Created attachment 113019 [details] patch v2

Ryosuke Niwa

Comment 6 2011-10-31 00:20:47 PDT

Comment on attachment 113019 [details] patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=113019&action=review > Source/JavaScriptCore/ChangeLog:9 > + Reviewed by Ryosuke Niwa. Ugh... this line is supposed to appear ABOVE the description.

Michael Saboff

Comment 7 2011-10-31 09:10:52 PDT

The changes look good to me.

Alexey Proskuryakov

Comment 8 2011-10-31 10:16:01 PDT

Is this dead code? Otherwise, it should be possible to make a regression test.

Ryosuke Niwa

Comment 9 2011-10-31 11:27:13 PDT

(In reply to comment #8) > Is this dead code? Otherwise, it should be possible to make a regression test. I believe this change is needed in an effort to support 8-bit string optimization.

WebKit Review Bot

Comment 10 2011-10-31 16:19:09 PDT

Comment on attachment 113019 [details] patch v2 Clearing flags on attachment: 113019 Committed r98903: <http://trac.webkit.org/changeset/98903>

WebKit Review Bot

Comment 11 2011-10-31 16:19:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.