Bug 71192

Summary:

Web Inspector: factor out ResourceUtils, clean up externs.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	yurys: review+, webkit.review.bot: commit-queue-

Pavel Feldman

Reported 2011-10-30 12:45:05 PDT

Patch to follow.

Attachments
Patch (36.67 KB, patch) 2011-10-30 12:47 PDT, Pavel Feldman	yurys: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-10-30 12:47:00 PDT

Created attachment 112998 [details] Patch

WebKit Review Bot

Comment 2 2011-10-30 21:26:25 PDT

Comment on attachment 112998 [details] Patch Attachment 112998 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10245228 New failing tests: inspector/debugger/selected-call-frame-after-formatting-source.html inspector/debugger/debugger-activation-crash2.html inspector/styles/css-live-edit.html inspector/debugger/watch-expressions-panel-switch.html inspector/debugger/set-breakpoint.html inspector/debugger/script-formatter.html inspector/debugger/open-close-open.html inspector/debugger/source-frame.html inspector/debugger/live-edit.html inspector/debugger/linkifier.html inspector/debugger/debugger-breakpoints-not-activated-on-reload.html inspector/debugger/pause-in-internal-script.html

Yury Semikhatsky

Comment 3 2011-10-30 22:53:26 PDT

Comment on attachment 112998 [details] Patch Please don't forget to fix the test failures before landing.

Pavel Feldman

Comment 4 2011-10-31 02:18:52 PDT

Committed r98840: <http://trac.webkit.org/changeset/98840>

Note You need to log in before you can comment on or make changes to this bug.