Bug 71142

Summary:

Whether backspace goes Back should be configurable

Product:

WebKit

Reporter:

John Sullivan <sullivan>

Component:

UI Events

Assignee:

John Sullivan <sullivan>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

aroben, jeffm

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch to add a WebCore setting and corresponding WebKit/WebKit2 preferences, with no change to current behavior	sam: review+
Same as last patch except also honors preference in WebFrameView.mm in WebKit	sam: review+
Move the frame->settings() test to after the !page test.	mitz: review+

John Sullivan

Reported 2011-10-28 14:23:19 PDT

Currently there’s code in the guts of the event-handling mechanism that causes the Backspace/Delete key to do a Go Back navigation (also Go Forward with a modifier-key variation) if it’s not intercepted by a form control. This setting should be configurable so that a client can choose to suppress it.

Attachments
Patch to add a WebCore setting and corresponding WebKit/WebKit2 preferences, with no change to current behavior (12.19 KB, patch) 2011-10-28 14:38 PDT, John Sullivan	sam: review+	Details Formatted Diff Diff
Same as last patch except also honors preference in WebFrameView.mm in WebKit (12.98 KB, patch) 2011-10-28 14:59 PDT, John Sullivan	sam: review+	Details Formatted Diff Diff
Move the frame->settings() test to after the !page test. (1.43 KB, patch) 2011-10-28 17:30 PDT, John Sullivan	mitz: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

John Sullivan

Comment 1 2011-10-28 14:38:50 PDT

Created attachment 112912 [details] Patch to add a WebCore setting and corresponding WebKit/WebKit2 preferences, with no change to current behavior

Adam Roben (:aroben)

Comment 2 2011-10-28 14:45:15 PDT

We often try to add tests to TestWebKitAPI for changes like this these days.

John Sullivan

Comment 3 2011-10-28 14:49:54 PDT

I’ll look into adding a TestWebKitAPI test separately. No promises though!

John Sullivan

Comment 4 2011-10-28 14:59:12 PDT

Ah, I realize that I need to honor this new preference in WebFrameView in WebKit (as well as in the event-handling code in WebCore; not sure if the WebFrameView one still needs to exist, but since it does exist, it should honor this preference). Tweaked patch forthcoming.

John Sullivan

Comment 5 2011-10-28 14:59:54 PDT

Created attachment 112918 [details] Same as last patch except also honors preference in WebFrameView.mm in WebKit

John Sullivan

Comment 6 2011-10-28 15:08:06 PDT

Fixed in http://trac.webkit.org/changeset/98769

Darin Adler

Comment 7 2011-10-28 17:11:45 PDT

Comment on attachment 112912 [details] Patch to add a WebCore setting and corresponding WebKit/WebKit2 preferences, with no change to current behavior View in context: https://bugs.webkit.org/attachment.cgi?id=112912&action=review > Source/WebCore/page/EventHandler.cpp:3028 > + if (!m_frame->settings()->backspaceKeyNavigationEnabled()) > + return; Since the settings object actually hangs off the page, not the frame, this needs to be done after checking the page is null.

John Sullivan

Comment 8 2011-10-28 17:27:08 PDT

I see. I’ve checked it in, so I’ll fix that in a separate patch.

John Sullivan

Comment 9 2011-10-28 17:30:23 PDT

Reopening for change Darin mentioned.

John Sullivan

Comment 10 2011-10-28 17:30:55 PDT

Created attachment 112949 [details] Move the frame->settings() test to after the !page test.

John Sullivan

Comment 11 2011-10-28 17:33:05 PDT

Checked in this additional change in 98788.

Note You need to log in before you can comment on or make changes to this bug.